BIND 10 #366: The socket creator process

[BIND 10 Development]

#366: The socket creator process
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  vorner
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:
                 Priority:  major    |  Sprint-20110419
                Component:           |           Resolution:
  Unclassified                       |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  0.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  UnAssigned => vorner


Comment:

 Looks ok (I assume that the moved fd_ stuff has not changed, if it has, I
 can take a closer look at that).

 Regarding the socket creator code, I'd like to see a bit of whitespace
 between the macros (in fact, I'd even place them outside of the function,
 directly above it, to better show what the function does, but the current
 location is defendable as well).

 It would seem the README could use a little bit more info on exactly what
 is sent back on success (and when).

 Is the (empty) send_fd in sockcreator.cc supposed to be used anywhere?
 (from what I can tell only the 'real' one is used, and a dummy test for
 testing). I suspect this simply got left after the move.

-- 
Ticket URL: <http://bind10.isc.org/ticket/366#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development