BIND 10 #843: Remove range check from OutputBuffer

[BIND 10 Development]

#843: Remove range check from OutputBuffer
-------------------------------------+-------------------------------------
           Reporter:  vorner         |                      Owner:
               Type:  task           |                     Status:  new
           Priority:  minor          |                  Milestone:  Year 3
          Component:  Unclassified   |  Task Backlog
          Sensitive:  0              |                   Keywords:
Add Hours to Ticket:  0              |  Estimated Number of Hours:  0
        Total Hours:  0              |                  Billable?:  1
                                     |                  Internal?:  0
-------------------------------------+-------------------------------------
 As mentioned in #536, the `OutputBuffer` contains a range check in its
 `operator[]`. Removing it increases QPS from 26kQPS to 32kQPS, so it
 indicates the check has some performance penalty. However, as it is output
 buffer, accessing elements out of its range is always a bug (or at last I
 think so), so the exception should never be caught anyway. Therefore the
 range check only makes better crash message when there's a bug.

 We should decide if it's worth removing or not.

-- 
Ticket URL: <http://bind10.isc.org/ticket/843>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development