BIND 10 #363: "H" and "I" are probably harmful for PyArg_ParseTuple()
BIND 10 Development
do-not-reply at isc.org
Fri Apr 8 01:07:27 UTC 2011
#363: "H" and "I" are probably harmful for PyArg_ParseTuple()
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: jinmei
Type: defect | Status: reviewing
Priority: minor | Milestone:
Component: | Sprint-20110419
DNSPacket API | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:20 zzchen_pku]:
> > And, such updates would be beyond the scope of this ticket, and it
would make more sense to leave them to a separate ticket.
> Got it :), I have created #842 for it.
Okay, thanks. I've updated that text with a reference to this ticket
for the background.
> > From a quick eye-grep, no, but the point is that it would be safer to
make it sure by tests. Boundary conditions are one of the common points
where human beings make mistakes.
> Refined the unittest and added more boundary test cases.
In name_python_test.py, this test seems to be duplicate. Missing
cleanup or intentional?
{{{
s = self.name1.split(0)
self.assertEqual("example.com.", s.to_text())
}}}
I've also added some more tests for boundary cases (pushed).
If the above is just missing cleanup. please clean it up and merge it.
--
Ticket URL: <http://bind10.isc.org/ticket/363#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list