BIND 10 #806: Implement RP record type

BIND 10 Development do-not-reply at isc.org
Mon Apr 11 08:37:23 UTC 2011


#806: Implement RP record type
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:
                 Priority:           |  Sprint-20110419
  critical                           |           Resolution:
                Component:           |            Sensitive:  0
  b10-auth                           |  Add Hours to Ticket:  0
                 Keywords:           |          Total Hours:  0
Estimated Number of Hours:  3.0      |
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:6 vorner]:

 > I have two things:
 >  * The comment in `toWireRenderer` seems misleading: {{{// similar to
 toWireBuffer, but names in RDATA should be compressed}}}. Actually, the
 names must not be compressed (as noted in the code) and the testdata have
 them uncompressed as well, the comment suggests that they should be
 compressed.

 Ah, good catch.  It was an error due to naive copy paste.  Fixed.  (Note:
 I first thought it was derived from the generic rdata.h and made some
 editorial fix that is not actually related to this point: commit 31b9619.
 I've not reverted this cleanup)

 >  * The build fails for me with
 {{{../../../../src/lib/dns/.libs/libdns++.so: undefined reference to
 `isc::dns::rdata::generic::RP::RP(isc::dns::rdata::generic::RP
 const&)'}}}. The header of the copy constructor is generated with the
 common members.

 Hmm, it's strange that it didn't cause an error with clang++ (since we
 cannot use the default copy constructor for the base Rdata class we should
 define it explicitly).  Anyway, the simple and correct fix to this is to
 define the trivial copy constructor.  Done in commit ad04d07.

-- 
Ticket URL: <http://bind10.isc.org/ticket/806#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list