BIND 10 #860: sqlite3 data source should separate DONE and other errors

BIND 10 Development do-not-reply at isc.org
Fri Apr 22 06:09:02 UTC 2011


#860: sqlite3 data source should separate DONE and other errors
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  major         |                    Milestone:  New
           Component:  data source   |  Tasks
           Sensitive:  0             |                     Keywords:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 See #851 (espeically its initial description).  Conceptually, this means
 instead of doing this:
 {{{
     rc = sqlite3_step(dbparameters->q_zone_);
     const int i = (rc == SQLITE_ROW) ?
         sqlite3_column_int(dbparameters->q_zone_, 0) : -1;
 }}}
 we should do it this way:
 {{{
     rc = sqlite3_step(dbparameters->q_zone_);
     if (rc != SQLITE_ROW && rc != SQLITE_DONW) {
         throw some_exception;
     }
     const int i = (rc == SQLITE_ROW) ?
         sqlite3_column_int(dbparameters->q_zone_, 0) : -1;
 }}}

 It's basically straightforward, but since a naive approach would result
 in the same patter repeated in various places, we'll probably also need
 some kind of refactoring.

-- 
Ticket URL: <http://bind10.isc.org/ticket/860>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list