BIND 10 #598: Resolver DO bit, forwarder pass DO bit

[BIND 10 Development]

#598: Resolver DO bit, forwarder pass DO bit
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  zhanglikun
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20110503
                  Component:         |            Resolution:
  resolver                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => zhanglikun


Comment:

 Hello

 Few notes:
  * Isn't this overcomplicated? (in `IOFetch::IOFetch`)

  {{{#!cpp
  Message::HeaderFlag flag = Message::HEADERFLAG_RD;
  msg->setHeaderFlag(flag, query_message->getHeaderFlag(flag));
  flag = Message::HEADERFLAG_CD;
  msg->setHeaderFlag(flag, query_message->getHeaderFlag(flag));
  }}}

  Wouldn't it be enough to just write:

  {{{#!cpp
  msg->setHeaderFlag(Message::HEADERFLAG_RD,
 message->getHeaderFlag(Message::HEADERFLAG_RD));
  }}}

  Or, if that would be too long, maybe a function to copy a flag? (But yes,
 this is probably only aestetical matter, if you like your way more, it's
 OK).

  * It seems the RunningQuery got the ability to retry over TCP. The
 forward query doesn't have the ability (or, doesn't seem to have it, I
 don't see it in the code and there's a XXX comment about it). What should
 the forwarder do with TCP anyway? Ask over UDP if the request come over
 UDP and use TCP if it comes over TCP? Is it possible with our current
 framework? Anyway, this is probably for another task. In that case, could
 you create a ticket for it?

  * There seem to be problem with `RecursiveQueryTest.lowtimeouts` for some
 reason. It failed once and segfaulted once when I run it (I admit my
 computer is under quite heavy load, but that should not be a problem I
 guess):

  {{{
  [ RUN      ] RecursiveQueryTest.lowtimeouts
  recursive_query_unittest.cc:816: Failure
  Value of: num
    Actual: 0
    Expected: 1
  [  FAILED  ] RecursiveQueryTest.lowtimeouts (1003 ms)
  }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/598#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development