BIND 10 #812: TSIG: Signing messages

[BIND 10 Development]

#812: TSIG: Signing messages
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110503
                   Priority:         |            Resolution:
  blocker                            |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  Unclassified                       |  Estimated Difficulty:  8.0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:  tsig   |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 '''src/lib/dns/tsigkey.{cc,h}'''
 > Yeah, this is one of the points I was not sure. I chose
 getCryptoAlgorithm() to make it clear that it would be used for
 libcryptolink stuff. But since that might also be clear from the return
 type, I'm fine with changing it to getAlgorithm() if you prefer it.
 I think it would be worth it (either that or change getAlgorithmName() to
 getCryptoAlgorithmName()).  It was just that two names seemed to imply
 that there were two algorithms present.

 '''src/lib/dns/tsig.{cc,h}'''
 > I've tried to clarify that with added comments (commit daf48e8), please
 check.
 The new comments provide suitable clarification.

 > I'd personally hold off until we see at least one other use case. And,
 in any case, I'd defer it to a separate ticket.
 That seems sensible.

 '''src/lib/dns/tsigerror.{cc,h}''
 > But at the same time I love consistency:-) So, if you strongly want to
 see consistent line-break rule in this file, I don't mind changing it.
 I think it would look better, but I'll leave it up to you.

 '''src/lib/util/unittests/Makefile.am'''
 > My suggestion at the moment is to have dns/tests link libutil_io.la and
 create a separate ticket to resolve the dependency problem in a cleaner
 way.
 That is OK.

 '''src/lib/util/unittests/newhook.{cc,h}'''
 > Okay, I've added some comments (commit 78bd2b7)
 They are OK

 All seems OK, so you can continue with the rest of the work on this
 ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/812#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development