BIND 10 #1128: RR type implementation: SRV

[BIND 10 Development]

#1128: RR type implementation: SRV
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:  major  |  Sprint-20110802
                  Component:         |            Resolution:
  DNSPacket API                      |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 zzchen_pku]:

 > > I'll create a new ticket for that refactor of getToken() and
 tokenToNum() (i have a proposed patch)
 > >
 > > I've pushed one small change to a Makefile (EXTRA_DIST values weren't
 updated after the moving of the source files), to make distcheck work.
 > >
 > > IMO it's ready to merge, though we may want to ask Jinmei if he's
 happy with the documentation now.
 > Ok, I'll reassign it to jinmei.
 > Thanks for your review.

 Comment updates look mostly okay, but I noticed one error (the class
 description wasn't close enough to the definition) and one possible
 clarification (why we accept compressed targets), and made proposed
 fixes.  BTW I'd suggest running doxygen when you make non trivial
 changes to the documentation (like this one, which is a new set of
 doc); the kind of errors that I noticed can be easily detected by
 quickly browsing the doxygen output.

 I'm okay with the doc with my proposed changes.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1128#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development