BIND 10 #1061: introduce DatabaseClient (or DatabaseDataSourceClient)

BIND 10 Development do-not-reply at isc.org
Wed Aug 3 09:50:32 UTC 2011


#1061: introduce DatabaseClient (or DatabaseDataSourceClient)
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  assigned
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110816
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => assigned


Comment:

 Hello

 It should be ready for review. The generic part should be OK, but I'm not
 sure about few details with the SQLite3Connection:
  * I did copy paste a lot of code (and found a bug that the hasExactZone
 does not honor the class at all), and some of it is not needed yet. I put
 it into a comment for now so it doesn't have to be found in the original
 code every time. I'd like it to either get uncommented soon or deleted if
 it turns out it is not needed.
  * I don't think the two-phase initialization of constructor and calling
 init is needed, so I put the parameters to the constructor directly. If
 the configuration is changed, a new connection can be created and the old
 one destroyed. I believe it is simpler this way, but I don't know what was
 the original idea here.
  * The constructor takes the config now. Maybe providing the needed data
 directly would be better, so it would be config-format independent and the
 thing creating it would handle configs?
  * Do we want to support custom database schemas (so that user would
 provide the queries to DB in some kind of config) in future? I guess it's
 too early to add support for it now, but it looks useful if user has some
 kind of bigger database (but maybe more in case of mysql or other server-
 client database).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1061#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list