BIND 10 #878: Code to bind to address/port
BIND 10 Development
do-not-reply at isc.org
Thu Aug 4 20:23:24 UTC 2011
#878: Code to bind to address/port
-------------------------------------+-------------------------------------
Reporter: shane | Owner: UnAssigned
Type: | Status: reviewing
enhancement | Milestone: Sprint-
Priority: major | DHCP-20110712
Component: dhcp | Resolution:
Keywords: | Sensitive: 0
Defect Severity: N/A | Sub-Project: DHCP
Feature Depending on Ticket: dhcp- | Estimated Difficulty: 3.0
echo | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by tomek):
Changes suggested by Jinmei are done. The code now better adheres to
coding standards, code is (hopefully) exception safe, cppcheck warnings
removed, gtest code is now in unnamed namespace.
gtest functions stay public. They are public for a reason - they are used
in test fixtures to poke with internal workings of tests classes.
I'm aware of serious limitations of the code:
- interface detection is not implemented. This makes automated/portable
testing very difficult. That's why the code is less tested than I would
like it to be. Once interface detection is implemented, more thorough
tests will be implemented.
- code uses cout stream, rather than logging
- we should probably define isc::dhcp or isc:dhcp6 namespace, rather than
use generic isc
- Pkt6 class requires serious development. For now it is just a generic
packet container.
--
Ticket URL: <http://bind10.isc.org/ticket/878#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list