BIND 10 #1061: introduce DatabaseClient (or DatabaseDataSourceClient)
BIND 10 Development
do-not-reply at isc.org
Fri Aug 5 12:38:07 UTC 2011
#1061: introduce DatabaseClient (or DatabaseDataSourceClient)
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110816
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => vorner
Comment:
> For another, the current getZone is the lowest possible manipulation
with the DB, like select id from zones when name =. It can't be done in
DB-independent way. Maybe the name could be different?
I think a different name would be better. A database connection has a
special meaning; using the term for a class in BIND 10 runs the risk of
confusion with the underlying database connections.
> (regarding comment in header for !FindZone)
> Should I reword it somehow?
I think so. I'm not clear what the restriction on the returned object is
or why it is there.
>> class DatabaseClient::Finder
>> getOrigin(), getClass() and find() do not have header comments.
> Do they need one?
In that case, a comment that these are methods defined in a base class
would be OK.
File changes are OK.
--
Ticket URL: <http://bind10.isc.org/ticket/1061#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list