BIND 10 #929: Add an interface into cfgmgr to get statistics list of each module

BIND 10 Development do-not-reply at isc.org
Tue Aug 9 06:35:34 UTC 2011


#929: Add an interface into cfgmgr to get statistics list of each module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110816
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  15.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => jelte


Comment:

 Replying to [comment:13 jelte]:
 Thank you for giving more comments.

 > - there doesn't appear to be a test for that change (if i remove the
 added check, it doesn't appear to fail), is it possible to add one?

 I added such tests. It's git 330dd7915a9a6b808db7b65b236e733e42401b8d.

 > - fixed-size buffers are always scary wrt buffer overflows. From the
 looks of the code, it seems to be safe here, but please add a comment why
 this is so (also so that if anyone wants to change said code he is aware
 of any danger)

 I couldn't consider enough for buffer overflows. I changed more the code
 to check time format. It's git-id same to above. Sorry, could you see
 that?

 Thanks,

-- 
Ticket URL: <http://bind10.isc.org/ticket/929#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list