BIND 10 #1062: add a base for DatabaseZoneHandle::find()

BIND 10 Development do-not-reply at isc.org
Thu Aug 11 21:18:07 UTC 2011


#1062: add a base for DatabaseZoneHandle::find()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110816
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 It's now almost okay (I noticed a typo in.mes and fixed it), one minor
 last thing: we should probably print the DB name in the following logs
 too:
 {{{
     if (!result_rrset) {
         if (records_found) {
             logger.debug(DBG_TRACE_DETAILED,
 DATASRC_DATABASE_FOUND_NXRRSET)
                         .arg(name).arg(getClass()).arg(type);
             result_status = NXRRSET;
         } else {
             logger.debug(DBG_TRACE_DETAILED,
 DATASRC_DATABASE_FOUND_NXDOMAIN)
                         .arg(name).arg(getClass()).arg(type);
             result_status = NXDOMAIN;
         }
     } else {
         sig_store.appendSignatures(result_rrset);
         logger.debug(DBG_TRACE_DETAILED,
                     DATASRC_DATABASE_FOUND_RRSET).arg(*result_rrset);
     }
 }}}

 This should be quite straightforward, so I don't think we need another
 cycle of review just for that.  Please update the code as you think
 appropriate and merge it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1062#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list