BIND 10 #878: Code to bind to address/port

[BIND 10 Development]

#878: Code to bind to address/port
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  shane
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:  Sprint-
                   Priority:  major  |  DHCP-20110712
                  Component:  dhcp   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:  dhcp-  |  Estimated Difficulty:  3.0
  echo                               |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by shane):

 Okay, looking at the Addr6 bit:

   * I note that the asio library has some IPv6 functions in its asio
 library, and we use that library:

 http://www.boost.org/doc/libs/1_47_0/doc/html/boost_asio/reference/ip__address_v6.html

     It may not be what we need, but in the future make sure to have a look
 for existing libraries.

   * I don't like the overloaded constructor from a character constant. It
 makes it non-obvious from reading the code what is actually going on. I'd
 suggest adding a non-member factory function to create Addr6 instances
 from printable strings, ParseAddr6() or something like that.

   * We don't use hard tabs in BIND 10. '''s/^^I/        /g''' should fix
 it. :)

   * linkLocal() and multicast() should contain a comment or even better a
 reference to the RFCs where they are defined.

   * Why don't you use INET6_ADDRSTRLEN which is guaranteed to be long
 enough for an IPv6 string, rather than defining MAX_ADDRESS_STRING_LEN on
 our own?

-- 
Ticket URL: <http://bind10.isc.org/ticket/878#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development