BIND 10 #930: update stats modules to get statistics list from cfgmgr, and define the list in spec file of each module
BIND 10 Development
do-not-reply at isc.org
Sat Aug 13 11:07:45 UTC 2011
#930: update stats modules to get statistics list from cfgmgr, and define the
list in spec file of each module
-------------------------------------+-------------------------------------
Reporter: | Owner: naokikambe
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110816
Priority: major | Resolution:
Component: | Sensitive: 0
statistics | Sub-Project: DNS
Keywords: | Estimated Difficulty: 20.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => naokikambe
Comment:
Hello
Replying to [comment:14 naokikambe]:
> Replying to [comment:13 vorner]:
> > OK, let's leave it this way for now, because it doesn't look trivial.
But could you, please, create a ticket to get rid of that sleep somehow? I
still think it is not really nice to have it there, though I don't see an
easy way to avoid it right now.
>
> OK. I haven't created a ticket for it yet, but I made a draft. How about
this?:
> {{{
> Titile: find another solution to synchronize between threads used in
> unittests for stats
>
> Description: As we discussed in #930, time.sleep() is used to
> synchronize between threads used in unittests for stats. It is
> not appropriate. Because in our buildbots, the timer is
> inaccurate and timeout might be not enough.
> }}}
I'd also include another reason, the sleep slows down the tests, but yes,
this one is OK.
> > So, I believe the branch is ready.
> I'm waiting for finishing #929. trac930 depends on trac929, and trac929
is already merged into trac930. If #929 is ok, I will merge trac930 into
master.
ACK.
With regards.
--
Ticket URL: <http://bind10.isc.org/ticket/930#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list