BIND 10 #1063: support delegation (NS and DNAME) case for DatabaseZoneHandle::find()
BIND 10 Development
do-not-reply at isc.org
Mon Aug 15 15:42:36 UTC 2011
#1063: support delegation (NS and DNAME) case for DatabaseZoneHandle::find()
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110816
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 4.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: UnAssigned => vorner
Comment:
Again, I pushed some small style fixes.
This may start to get complicated enough to start adding some trace-level
logging in find()
I must say I can't immediately think of a much better interface for
getRRset()
right now, normally one would use a bitwise flags argument if there are
multiple
'options' like this, but direct booleans seem easier given the way is is
used.
Regarding tests, splitting them up is probably a good idea :)
One thing we could add is a test where some data is 'hidden' by a
delegation (i.e. what happens if i have a bad zone example.org with
{{{
sub.example.org. NS ns.foo.bar
www.sub.example.org. A 192.0.2.1
}}}
because of the delegation that A record is out-of-zone data, and a good
zone-reader should not accept it, but we may not have control over the db
since
we go top down i guess it should just give back the delegation and ignore
the
record, but it is a test we can add.
Oh and the somewhat simpler query-for-multiple-levels-below-delegation
perhaps, as another
'corner' case (a simple some.levels.below.delegation.example.org. would
suffice i think).
For the rest it looks OK.
--
Ticket URL: <http://bind10.isc.org/ticket/1063#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list