BIND 10 #1183: data source refactor refactor

[BIND 10 Development]

#1183: data source refactor refactor
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  task          |                       Status:  new
            Priority:  major         |                    Milestone:
           Component:  data source   |  Sprint-20110830
           Sensitive:  0             |                     Keywords:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 "We need to go deeper!"

 During the handling of the 106X tickets, a few changes were deferred,
 partly so that the branches would not diverge too much, and partly because
 some of the branches already contained some parts that other branches
 could use for this.

 Most importantly, the calls to searchForRecords() and the related
 getNextRecord() should be done in a RAII style. #1067 added an iterator-
 style return value for getAllRecords(), and we should reuse that for
 searhcForRecords() (which i propose to rename to getRecords()). getNext()
 would then be a method of the object searchFor() returns.

 The find() method(s) naturally need to be updated for this. A number of
 checks and catches can then be removed, as the RAII idiom would take care
 of the cleanup that is now done in a number of catches.

 Also, since 1067 has been changed slightly to conform interface-wise to
 the changes in 1062, we can now make the size of the columns array in
 getNext() compiler-enforcable (by making the function parameter a
 reference to a fixed-size array).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1183>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development