BIND 10 #519: msgq socket recv hang

[BIND 10 Development]

#519: msgq socket recv hang
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  naokikambe
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20110816
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by zhanglikun):

 * owner:  zhanglikun => naokikambe


Comment:

 Replying to [comment:16 naokikambe]:
 > Hello,
 >
 > I think this problem is basically that msgq cannot handle asynchronous
 queuing properly, but I don't know where is wrong exactly. Anyway, the
 changes seem to be only for bob and stats, but these almost look OK. There
 are some minor points.

 Yes, msgq can't handle asynchronous message, as Jeremy pointed out, some
 orphan message is not read(Recv-Q not eqaul to Send-Q), for more
 information, see comments 13.

 >
 > - A new command 'getstats' is introduced into bob. Is this for internal
 use only? If no, do we need to define it in bob.spec and to document it in
 the manpage of stats and in !ChangeLog? Anyway, when I added 'sendstats'
 to bob at #521, I documented these.

 Yes, 'getstats' will be a internal command.

 >
 > - I couldn't see any test for the command in bob. Don't we need?

 Added, please have a review.

 >
 > - If !SessionTimeout raised in stats when waiting for answer from bob,
 should we just ignore it?

 I add a catch for the SessionTimeout exception, and it will be ingored.

 >
 > - If bob returns non-zero to stats, wouldn't any message be needed here?

 I am not sure what you mean here, sorry.

 >
 > - Actually 'sendstats' isn't needed. Should we remove it?

 I am not sure whether bind10 will send other stat data to stats module by
 hand in the future, if it's just used for get's boss's start-time, I will
 remove it.

 >
 > - Do we need to check that argument which bob returns is dictionary
 type?
 >
 Added, please check.

 > Best

-- 
Ticket URL: <http://bind10.isc.org/ticket/519#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development