BIND 10 #1183: data source refactor refactor
BIND 10 Development
do-not-reply at isc.org
Thu Aug 18 14:58:07 UTC 2011
#1183: data source refactor refactor
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: UnAssigned
Type: task | Status: reviewing
Priority: major | Milestone:
Component: data | Sprint-20110830
source | Resolution:
Keywords: | Sensitive: 0
Defect Severity: N/A | Sub-Project: DNS
Feature Depending on Ticket: | Estimated Difficulty: 0
Add Hours to Ticket: 0 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => UnAssigned
* status: assigned => reviewing
Comment:
Ready for review.
- added getRecords(), based on the old searchForRecords, but returns an
IteratorContextPtr similar to getAllRecords(). Since getRecords takes the
name, the implementation actually skips copying the name column on calls
to getNext()
- tests updated to use this interface, and now useless tests removed
- removed the old api calls (searchForRecords(), getNextRecord(), and
resetSearch())
- getNext() takes a reference-to-array now so we can do compile-time
checks
- remove Name argument to getAllRecords (was unused an unnecessary, it
already takes the zone id)
- also took the chance to fix the memleak in failed creation of
sqlite3accessor, by making dbparameters_ a scoped_ptr
--
Ticket URL: <http://bind10.isc.org/ticket/1183#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list