BIND 10 #510: Implement dictionary-type variable size counter

[BIND 10 Development]

#510: Implement dictionary-type variable size counter
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  y-aharen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110830
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  statistics                         |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => y-aharen


Comment:

 I have taken the liberty to commit and push a few indentation fixes, and I
 changed the logger initialization call in run_unittests.cc, see commit
 657349ae281dcdf737b187d0be2cd7d0e4fa92a7


 In general, the code looks OK. I do wonder why we need an implementation
 of a
 dictionary, wasn't a direct std::map enough? (or is it impossible to use
 the
 elements by reference then?)



 counter_dict_unittests.cc: if the test fixture doesn't do any setup or
 cleanup,
 and holds no state, it's really not nessecary, and the tests can also be
 done
 with the TEST() macro instead of the TEST_F() macro. In this case, nearly
 every
 test however does the same initial thing (define
 counters(NUMBER_OF_ITEMS)), so
 that could actually go into the fixture.

 counter_unittests.cc: perhaps the incrementCounterItem test can also try
 another
 round of inc() calls after the three EXPECT_EQ()'s, then check them again,
 so
 that the tests also make sure they do not return fixed values.

-- 
Ticket URL: <http://bind10.isc.org/ticket/510#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development