BIND 10 #1292: Xfrin retransfer shared object "sqlite3_ds.so" not found

[BIND 10 Development]

#1292: Xfrin retransfer shared object "sqlite3_ds.so" not found
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20111206
  critical                           |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  High   |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  5      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Replying to [comment:31 jinmei]:
 > The branch now seems to be mostly okay.  I have a few comments on
 > FactoryTest::paths.
 >
 > - for pathtestHelper() I'd make sure the actual error string has a
 >   sufficient length:
 > {{{#!c++
 >     ASSERT_LT(expected_error.size(), error.size());
 >     EXPECT_EQ(expected_error, error.substr(0, expected_error.size()));
 > }}}
 > - I think we should also cover the case for an empty string.
 > - I'd also like to test the case when B10_FROM_BUILD isn't set.  That
 >   would require unsetenv it once (and probably recover it immediately
 >   after that specific test case), though.  Hopefully its side effect
 >   is acceptable.
 > - I'd also check some tricky name like "no_such_file.so.noso" (the
 >   intermediate '.so' shouldn't confuse the parser)

 Ack, all added

 > - What should we do if we just pass ".so" (no prefix)?

 Hmm, yes, that should probably explicitely fail too, added a check for
 that.

 BTW, also changed the error that is raised to DataSourceLibraryError
 (instead of DataSourceError)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1292#comment:33>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development