BIND 10 #1427: Socket cache

[BIND 10 Development]

#1427: Socket cache
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111206
                  Component:  Boss   |            Resolution:
  of BIND                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
  Socket creator                     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 one style issue; the nameCompatible() method name isn't following the
 style guideline (should be share_compatible())

 In general the code looks ok, the spaghetti of sets and dicts is a bit
 worrying though. Not so much as that it is too complicated as it is,
 but what worries me is when other people might need to change
 something in the future. But apart from adding some graph somewhere
 which will no doubt go stale I don't really have any suggestion for it,
 so you may just ignore this worry :p

 And some minor, debatable style issues, both of there are a matter of
 taste though;

 there are a few instances where emptiness is checked with 'foo ==
 set()'. I'd personally prefer len(foo) == 0

 similarly, sets have a copy() method, which i would personally
 choose over set(foo)

 anyhow, these are minor, and apart from the name thing in the
 beginning, I think this code can be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1427#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development