BIND 10 #1299: compare SOA serial in xfrin

[BIND 10 Development]

#1299: compare SOA serial in xfrin
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  accepted
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20111206
  blocker                            |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  AXFR-  |           Total Hours:  0
  in                                 |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac1299 is ready for review.

 (As always?) The branch resulted in a bit bigger than I originally
 expected.  If the branch is deemed to big to review as a whole, the
 following categorization might help:

 - The first two commits are separate initial cleanups and can be
   reviewed separately.
 - The third one (4e636c3) is an independent bug fix.  But the rest of
   the code depends on it, so I included it in this branch.  This is a
   completely independent change and can be reviewed separately.
 - Commits from 8376919 to 50fdb09 (inclusive) are one of the two main
   subjects of this task and handles SOA serial comparison for SOA
   query responses.  This part was relatively big to handle various
   validations on the responses (not really the subject of this task
   but the existing code was just way too native about bogus
   responses.)
 - The last commit (b3c9fff) was the second part of the  main subject
   of this task and handles SOA serial comparison for IXFR responses.

 Proposed changelog entry is as follows:
 {{{
 337.?   [bug]           jinmei
         b10-xfrin didn't check SOA serials of SOA and IXFR responses,
         which resulted in unnecessary transfer or unexpected IXFR
         timeouts (these issues were not overlooked but deferred to be
         fixed until #1278 was completed).  Validation on responses to SOA
         queries were tighten, too.
         (Trac #1299, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1299#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development