BIND 10 #1427: Socket cache

BIND 10 Development do-not-reply at isc.org
Mon Dec 5 10:58:00 UTC 2011


#1427: Socket cache
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111206
                  Component:  Boss   |            Resolution:
  of BIND                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
  Socket creator                     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:5 vorner]:
 >
 > Well, there would be other option, which is slower and probably more
 work to code, but it would be simpler with regards to the structure. The
 sockets could be in a list and a linear search for whatever is needed
 would be performed each time. The advantage would be there would be only
 one list, not multiple indexing hashes and stuff. But I personally prefer
 this approach, as it is cleaner design-wise and is already written. Or
 should I change it?
 >

 No this is fine

 > > there are a few instances where emptiness is checked with 'foo ==
 > > set()'. I'd personally prefer len(foo) == 0
 >
 > Hmm, changed. But not in the tests, as assertEqual(set(), var) will
 produce nicer are more useful output when it goes wrong.
 >

 ack

 >
 > I'll merge it once the other two are reviewed. No need to have it in
 master yet.
 >

 Ok

-- 
Ticket URL: <http://bind10.isc.org/ticket/1427#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list