BIND 10 #1383: FORMERR log messages not logged

[BIND 10 Development]

#1383: FORMERR log messages not logged
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111220
                  Component:         |            Resolution:
  logging                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:         |  Estimated Difficulty:  0
  Medium                             |           Total Hours:  0
Feature Depending on Ticket:  none   |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => UnAssigned
 * status:  assigned => reviewing


Comment:

 Several points:

 * The underlying problem - a query for teredo.ipv6.microsoft.com returns a
 FORMERR - occurred because one of the nameservers consulted when resolving
 the name rejects EDNS requests over UDP (see #1386).
 * The FORMERR was returned because in recursive_query.cc, if a response to
 an upstream query was received with an RCODE indicating an error, the
 packet was returned directly as the response to the original query.
 * The FORMERR was not logged because at the point where that decision was
 made, there was no debug logging statement.

 The changes made here are:

 * If a packet is received with an RCODE indicating an error, a SERVFAIL is
 returned instead of the original packet.  (This is going a bit beyond the
 remit of the ticket, but was discussed on Jabber.)
 * If a response to an upstream query is received that has any sort of
 error, a message is logged.  The actual message logged will depend on what
 sort of error is detected.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1383#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development