BIND 10 #1485: IOAddress::getAddress() breaks the concept of the asiolink

BIND 10 Development do-not-reply at isc.org
Wed Dec 7 03:02:56 UTC 2011


#1485: IOAddress::getAddress() breaks the concept of the asiolink
-------------------------------+-----------------------------------------
            Reporter:  jinmei  |                        Owner:
                Type:  defect  |                       Status:  new
            Priority:  major   |                    Milestone:  New Tasks
           Component:  dhcp    |                     Keywords:
           Sensitive:  0       |              Defect Severity:  N/A
         Sub-Project:  DHCP    |  Feature Depending on Ticket:
Estimated Difficulty:  0       |          Add Hours to Ticket:  0
         Total Hours:  0       |                    Internal?:  0
-------------------------------+-----------------------------------------
 I just happen to notice a (relatively) new method "getAddressas"
 is added to the asiolink::IOAddress class.

 This breaks the basic concept of asiolink: The fundamental idea of
 this wrapper module is to hide asio-specific details from other part
 of BIND 10.  Exposing asio's internal definition this way will make it
 useless.

 Please reconsider the interface: if the current IOAddress class is
 insufficient in terms of functionality, we need to add a higher level
 method to provide that necessary functionality, rather than exposing
 asio::ip::address and have the caller use the underlying ASIO
 interface.

 According to git blame and how this method is used, I guess it was
 added for DHCP, so I'm specifying "DHCP" as the sub-project.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1485>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list