BIND 10 #1383: FORMERR log messages not logged

[BIND 10 Development]

#1383: FORMERR log messages not logged
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  stephen
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111220
                  Component:         |            Resolution:
  logging                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:         |  Estimated Difficulty:  0
  Medium                             |           Total Hours:  0
Feature Depending on Ticket:  none   |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 I think the new log messages would be way more helpful if we also add the
 address of the server that sent the bad response to the log message
 ('response from %x for '?). This would require that said address be
 propagated a bit (through handleRecursiveAnswer() on to
 reportResponseClassifierError()), and therefore we can declare this out of
 scope for this ticket, but it may be nice to do it now :)

 nitpick warning; in nsas_messages.mes, EMPTY_RESPONSE says 'query
 completed successfully', but ERROR_RESPONSE says 'query successfully'
 (first one sounds better imo). Second one could probably also use a 'the'
 before RCODE.

 Oh and NSAS_NULL_RESPONSE one has 'completed' twice

 the actual code changes look good :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1383#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development