BIND 10 #1238: IfaceMgr support for IPv4 (incl. Socket binding for v4)

[BIND 10 Development]

#1238: IfaceMgr support for IPv4 (incl. Socket binding for v4)
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  tomek
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:  major  |  DHCP-20111207
                  Component:  dhcp4  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tomek


Comment:

 '''src/lib/dhcp/pkt4.cc'''[[BR]]
 Pkt4 constructor: memcpy is OK (don't change it now) but in general use
 std::copy as it is guranateed to do the right thing regardless on
 container.  (And as far as I can see from the header files, on Ubuntu it
 can resolve to a function !__builtin_memcpy, which I believe is a synonym
 for memcpy).

 unpack(): in the first "if" test, the operator "<" should have a space
 either side.

 '''Summary'''[[BR]]
 Make the change in unpack() and merge (I don't need to see it again).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1238#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development