BIND 10 #510: Implement dictionary-type variable size counter

[BIND 10 Development]

#510: Implement dictionary-type variable size counter
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20111220
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  statistics                         |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  Auth   |
  statistics                         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by y-aharen):

 * owner:  y-aharen => jelte


Comment:

 Replying to [comment:16 jelte]:
 >
 > Small note; after addressing review comments, you can assign the ticket
 back to the reviewer directly, there's no need to set it to unassigned
 again (in fact, that might cause it to be missed by the original
 reviewer).
 I'm sorry for your inconvenience. I'll keep it in mind.

 > > > counter_dict_unittests.cc: if the test fixture doesn't do any setup
 or cleanup,
 > > > and holds no state, it's really not nessecary, and the tests can
 also be done
 > > > with the TEST() macro instead of the TEST_F() macro. In this case,
 nearly every
 > > > test however does the same initial thing (define
 counters(NUMBER_OF_ITEMS)), so
 > > > that could actually go into the fixture.
 > > Yes, the tests requires initialization, the fixture is needed. If you
 have any suggestion, please let me know.
 > >
 >
 > I suggest we move the definition of the counter variable to the fixture,
 see my commit
 > 60fd293717cc45323cfb10cf06d5bd264fa083cc into branch trac510
 Thank you for your suggestion.
 CounterTest.invalidCounterSize does not use an instance of Counter in the
 fixture, so I moved the test to outside. I also modified tests in
 counter_dict_unittests.cc like you've figured. Thank you.

 If the changes are OK, I'll merge it into master.

-- 
Ticket URL: <http://bind10.isc.org/ticket/510#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development