BIND 10 #916: implement a prototype for stats snmp interface
BIND 10 Development
do-not-reply at isc.org
Thu Dec 8 16:47:14 UTC 2011
#916: implement a prototype for stats snmp interface
-------------------------------------+-------------------------------------
Reporter: | Owner: naokikambe
naokikambe | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20111220
Component: | Resolution:
statistics | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 10
Feature Depending on Ticket: SNMP | Total Hours: 0
stats |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => naokikambe
Comment:
Hello
As this is only prototype code, I didn't take a close look to stuff like
programming and style practices and mostly ignored the tests in the review
as well.
I've noticed some slight things, that may be just because this is simple
experimental version:
* It seems the list of items (or whatever it is called) is generated from
spec files manually rather than dynamically on the fly. As the daemons
might come and go and nothing really makes them say where their spec file
is (provided it is in a file at all), this doesn't seem correct.
* When a request is made, it downloads the whole set of statistics over
message bus and then picks the single one it needed. Shouldn't it ak only
for the needed data?
* While the http stats daemon servers its own http daemon, this one seems
to be used from inside some other external tool. It is slightly
inconsistent, but I don't think it should pose some other kind of problem.
Or, was this the purpose of the review? I'm not sure, if you don't want to
merge to master, it feels slightly unusual.
Thanks
--
Ticket URL: <http://bind10.isc.org/ticket/916#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list