BIND 10 #1239: Receiving data over V4

[BIND 10 Development]

#1239: Receiving data over V4
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  tomek
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:  major  |  DHCP-20111221
                  Component:  dhcp4  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  UnAssigned => tomek


Comment:

 Reviewing changes from 1ee6d8e7f892d929321b32e5577eb3a3be65a15e (Merge of
 1238) to 5be5e6a639a6a1c74761cae55a97f1fa46de5c6d

 '''src/bin/dhcp4/dhcp4_srv.cc'''[[BR]]
 No need to change this, as it is in a temporary debug output statement,
 but should use the static_cast<int>() construct to convert to an int.
 (Although as Pkt4::getType() returns a uint8_8, is there a need to
 convert?  Can't the ostream "<<" operator output uint8_t data?)

 '''src/bin/dhcp4/tests/dhcp4_srv_unittest.cc'''[[BR]]
 Dhcpv4SrvTest() constructor - unlink() should be indented by one more
 space.

 Dhcpv4SrvTest() constructor - "|" and ">" operators should have spaces
 round them.

 Dhcpv4SrvTest() constructor - should the code be reading "127.0.0.1"
 instead of "::1" for an IPV4 test?

 '''src/bin/dhcp6/tests/dhcp6_srv_unittest.cc'''[[BR]]
 Dhcpv6SrvTest() constructor - "|" and ">" operators should have spaces
 round them.

 There appears to be some commonality between the v4 and v6 tests that we
 should perhaps explore at some later time.


 '''src/lib/dhcp/iface_mgr.{cc,h}'''[[BR]]
 Not reviewed - these appear to be earlier version of code reviewed in
 another ticket.

 '''src/lib/dhcp/option.cc'''
 getUint16() and getUint32(): Rather than do the bit manipulation here,
 there are functions available in src/lib/util/io_utilities.h.  Using these
 may make the code clearer.

 '''src/lib/dhcp/option.h'''[[BR]]
 getUintXX() methods require Doxygen headers.


 '''src/lib/dhcp/pkt4.cc'''[[BR]]
 pack(): Need spaces around ">".

 '''src/lib/dns/benchmarks/Makefile'''[[BR]]
 For some reason, this file appears to have been added to git in this
 branch - it should be removed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1239#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development