BIND 10 #1505: build failed when configured without gtest

[BIND 10 Development]

#1505: build failed when configured without gtest
-------------------------------------+-------------------------------------
            Reporter:  naokikambe    |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  minor         |                    Milestone:  New
           Component:  data source   |  Tasks
           Sensitive:  0             |                     Keywords:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 I checked out git ebb759a07c67f015305019aa34ff20f69218a094 and tried to
 compile like this:
 {{{
 $ git clean -fd && autoreconf -i && ./configure && make
 }}}
 But the make unexpectedly failed. This is the tail of its errors.
 {{{
 /usr/include/gtest/gtest.h:1275: undefined reference to
 `testing::internal::EqFailure(char const*, char const*,
 testing::internal::String const&, testing::internal::String const&, bool)'
 /usr/include/gtest/gtest.h:1264: undefined reference to
 `testing::AssertionSuccess()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x10): undefined
 reference to `testing::Test::SetUp()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x14): undefined
 reference to `testing::Test::TearDown()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x30): undefined
 reference to `testing::Test::SetUp()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x34): undefined
 reference to `testing::Test::TearDown()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x50): undefined
 reference to `testing::Test::SetUp()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x54): undefined
 reference to `testing::Test::TearDown()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x70): undefined
 reference to `testing::Test::SetUp()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x74): undefined
 reference to `testing::Test::TearDown()'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0x94): undefined
 reference to `typeinfo for testing::Test'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0xac): undefined
 reference to `typeinfo for testing::Test'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0xc4): undefined
 reference to `typeinfo for testing::Test'
 run_unittests_factory-factory_unittest.o:(.data.rel.ro+0xdc): undefined
 reference to `typeinfo for testing::Test'
 run_unittests_factory-
 factory_unittest.o:(.data.rel.ro._ZTIN3isc7datasrc15DataSourceErrorE[typeinfo
 for isc::datasrc::DataSourceError]+0x8): undefined reference to `typeinfo
 for isc::Exception'
 run_unittests_factory-
 factory_unittest.o:(.data.rel.ro._ZTIN3isc14NotImplementedE[typeinfo for
 isc::NotImplemented]+0x8): undefined reference to `typeinfo for
 isc::Exception'
 collect2: ld returned 1 exit status
 make[7]: *** [run_unittests_factory] Error 1
 make[7]: Leaving directory `/home/kambe/git/src/lib/datasrc/tests'
 make[6]: *** [all-recursive] Error 1
 make[6]: Leaving directory `/home/kambe/git/src/lib/datasrc/tests'
 make[5]: *** [all-recursive] Error 1
 make[5]: Leaving directory `/home/kambe/git/src/lib/datasrc'
 make[4]: *** [all] Error 2
 make[4]: Leaving directory `/home/kambe/git/src/lib/datasrc'
 make[3]: *** [all-recursive] Error 1
 make[3]: Leaving directory `/home/kambe/git/src/lib'
 make[2]: *** [all-recursive] Error 1
 make[2]: Leaving directory `/home/kambe/git/src'
 make[1]: *** [all-recursive] Error 1
 make[1]: Leaving directory `/home/kambe/git'
 make: *** [all] Error 2
 }}}
 I think it needs "if HAVE_GTEST" in src/lib/datasrc/tests/Makefile.am. I
 also attached a proposed patch.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1505>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development