BIND 10 #1483: "findAll" method for ZoneFinder
BIND 10 Development
do-not-reply at isc.org
Fri Dec 16 10:54:00 UTC 2011
#1483: "findAll" method for ZoneFinder
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20111220
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0
Feature Depending on Ticket: DDNS | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => vorner
Comment:
Changes look good, a few comments:
Not related to this changeset specifically, but any idea what that boolean
'keep_doing' is, er, doing in Query::process()? This looks like some
variable and associated loop that isn't actually used anymore. (and hence
it looks like both can be removed)
The new log messages DATASRC_DATABASE_FOUND_ANY and
DATASRC_DATABASE_WILDCARD_ANY are not called with the number of arguments
they expect.
zone.h: should 'comfort' be 'conform' in the documentation of findAll()?
If we want to have doxygen produce zero warnings at some point (i believe
Jeremy had this intent, so that we can then enable a test for that as
well), we should not add more. So if so, I think we should have doxygen
comments for the parameters and return values of the new methods as well
(note that we can keep the reference to find(), and they can be quite
simple)
--
Ticket URL: <http://bind10.isc.org/ticket/1483#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list