BIND 10 #1522: Implementatio of isc::server_common::SocketRequestor

BIND 10 Development do-not-reply at isc.org
Thu Dec 22 16:08:48 UTC 2011


#1522: Implementatio of isc::server_common::SocketRequestor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120110
  blocker                            |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  Socket creator                     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Ok, it should be about ready for review.

 Branch is based on the commit mentioned above.

 Apart from adding a concrete instance that uses the ModuleCCSession and
 implements the abstract methods, most work went into the tests (as
 expected). Tests now contain a mini forking domain socket server which
 pumps stats+send_fd() data to a domain socket.

 A few not entirely related changes I needed:
 - cleanup() in socket_requestor.h, which removes the singleton and resets
 the static pointer (mostly needed for tests, i want to be able to
 initialize it again). But also useful for programs that want to clean up
 before they exit. (I left initTest() alone for now, and for this purpose
 it would not be correct, but we can probably merge the two)

 - added a groupSendMsg() and groupRecvMsg() call to ModuleCCSession (which
 are simple wrappers that directly call the equivalent methods of the
 internal msgq connection).


 oh and a few other notes:

 There are a few constants that I suspect will be needed in more places (at
 the top of socket_request.cc currently). If so we'll need to move them
 somewhere public. As I only needed them here now I put them in the .cc.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1522#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list