BIND 10 #1462: check SOA serial in xfrout

[BIND 10 Development]

#1462: check SOA serial in xfrout
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  kevin_tes
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120110
                  Component:         |            Resolution:
  xfrout                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  AXFR-  |           Total Hours:  0
  out                                |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by kevin_tes):

 Replying to [comment:8 jinmei]:
 > - xfrout.py compares serials as integers, which is not correct.  we
 >   need to use isc.dns.Serial objects.  See xfrin.
 I have changed it.
 > - before doing that, add a test case that fails due to the integer
 >   comparison (e.g. 0xffffffff "<" 1).  see, again, xfrin.  Then make
 >   the above change, and then confirm it fixes the problem.
 I think this case for a while,, and i think it does not to add this test.
 The first reason:The CURRENT_SOA_SERIAL=2011112001,SOA=2011119000 can test
 this case,and isc::dns::Serial has such test too.
 If add a test case that fails due to the integer comparison (e.g.
 0xffffffff "<" 1), i think it needs to change the  CURRENT_SOA_SERIAL,I
 think it does not need to change this exited codes too.

 > - ixfr-to-axfr test cases shouldn't be removed (we need to _SERIAL the
 >   test parameters and check the fallback behavior, not just remove it).
 > - I believe we need a changelog for it.
 I have recovered this test and changed the test parameters.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1462#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development