BIND 10 #1502: xfrin.diff module should distinguish RRSIGs for different covered

[BIND 10 Development]

#1502: xfrin.diff module should distinguish RRSIGs for different covered
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120110
                   Priority:         |            Resolution:
  critical                           |             Sensitive:  0
                  Component:  xfrin  |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  none   |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  UnAssigned => vorner


Comment:

 Hello

 I believe the code does what it should. However, the logic of same_type
 seems hard to follow. May I propose replacing the first two conditions
 with something like this?
 {{{#!python
         if rrset1.get_type() != isc.dns.RRType.RRSIG() or \
                 rrset2.get_type != isc.dns.RRType.RRSIG():
                 return rrset1.get_type() == rrset2.get_type()
 }}}

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/1502#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development