BIND 10 #1515: crash bindctl with "config add Auth/datasources[0]/zones" twice

[BIND 10 Development]

#1515: crash bindctl with "config add Auth/datasources[0]/zones" twice
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120110
  critical                           |            Resolution:
                  Component:  bind-  |             Sensitive:  0
  ctl                                |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  none   |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => reviewing


Comment:

 Hello

 It should be ready for review. The problem was it wanted to raise an
 exception, but part of the message wasn't converted to string (and it
 passed the tests because it was tested on lists containing strings only).
 Now it properly shows that the item is already in the list. I added a
 check to make sure such thing doesn't happen with named sets as well.

 However, I'm not sure if this is the correct fix. What is the reason for
 not allowing a list to have two same items? Should we remove the check and
 allow them instead?

 If not, this fix could have this changelog entry:
 {{{
 [bug]           vorner
 The bindctl no longer crashes when a duplicate non-string item is added to
 a list. An error is properly reported.
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1515#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development