BIND 10 #1522: Implementatio of isc::server_common::SocketRequestor

[BIND 10 Development]

#1522: Implementatio of isc::server_common::SocketRequestor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120110
  blocker                            |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  10
Feature Depending on Ticket:         |
  Socket creator                     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I forgot one more thing, not raised in the review but I noticed it
 myself: I guess we need to add some logging messages for the socket
 requestor.  So I added some.

 One thing that might raise a discussion is the format of address +
 port in:
 {{{
 % SOCKETREQUESTOR_GETSOCKET Received a %1 socket for [%2]:%3, FD=%4,
 token=%5, path=%6
 }}}
 I've used [address]:port regardless of the address family.  I know
 it doesn't conform to the consensus (addr:port for the old version of
 IP), but I expect we'll eventually introduce a formatter library to
 help produce consistent output.  So I didn't bother to introduce a
 local formatter for now.

-- 
Ticket URL: <https://bind10.isc.org/ticket/1522#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development