BIND 10 #438: C++ Logging

[BIND 10 Development]

#438: C++ Logging
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  stephen
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  R-Team-
                 Priority:  major    |  Sprint-20110208
                Component:  logging  |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  5.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jreed):

 I found some minor mistakes in trac438: wrong variable name, errant $,
 indent, missing $, and missing includes.

 {{{

 diff --git a/configure.ac b/configure.ac
 index c894c23..aa92558 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -336,7 +336,7 @@ AC_ARG_WITH([log4cxx],
      [specify directory where log4cxx is installed]),
    [
     log4cxx_include_path="${withval}/include";
 -   log4cxx_lib_path="${$withval}/lib"
 +   log4cxx_library_path="${withval}/lib"
    ])

  # If not specified, try some common paths.  These default to
 @@ -348,7 +348,7 @@ if test -z "$with_log4cxx"; then
         do
                 if test -d $d/include/log4cxx; then
                         log4cxx_include_path=$d/include
 -            log4cxx_library_path=$d/lib
 +                       log4cxx_library_path=$d/lib
                         break
                 fi
         done
 @@ -365,7 +365,7 @@ AC_SUBST(LOG4CXX_INCLUDES)

  LOG4CXX_LDFLAGS="-llog4cxx";
  if test "${log4cxx_library_path}"; then
 -    LOG4CXX_LDFLAGS="-L{log4cxx_library_path} -llog4cxx"
 +    LOG4CXX_LDFLAGS="-L${log4cxx_library_path} -llog4cxx"
  fi
  AC_SUBST(LOG4CXX_LDFLAGS)

 diff --git a/src/lib/log/Makefile.am b/src/lib/log/Makefile.am
 index 9171682..47e4f81 100644
 --- a/src/lib/log/Makefile.am
 +++ b/src/lib/log/Makefile.am
 @@ -2,6 +2,7 @@ SUBDIRS = . compiler tests

  AM_CPPFLAGS = -I$(top_builddir)/src/lib -I$(top_srcdir)/src/lib
  AM_CPPFLAGS += $(BOOST_INCLUDES)
 +AM_CPPFLAGS += $(LOG4CXX_INCLUDES)
  AM_CPPFLAGS += -I$(top_srcdir)/src/lib/log -I$(top_builddir)/src/lib/log

  CLEANFILES = *.gcno *.gcda

 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/438#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development