BIND 10 #494: Modify resolver to use abstract resolver interface

[BIND 10 Development]

#494: Modify resolver to use abstract resolver interface
-------------------------------------+-------------------------------------
                 Reporter:  shane    |                Owner:  jelte
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  R-Team-
                 Priority:  major    |  Sprint-20110208
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 Reviewed commit 640640363d2a29cc0f4ab8151ca5c02dc9f7c361.

 '''src/bin/msgq/msgq.py.in'''[[BR]]
 Comment: it looks as if the change should have been associated with
 another ticket.

 '''src/lib/asiolink/asiolink.cc'''[[BR]]
 !RunningQuery: references to server and server_ elements are commented
 out; should they be removed?

 RecursiveQuery::sendQuery() (first instance): a block of code around
 setting the resolver callback is commented out: should it be removed?

 '''src/lib/asiolink/asiolink.h'''[[BR]]
 In the Doxygen headers for sendQuery, the header for the first instance
 documents five parameters (when there are two).  In the second instance,
 the name of the second parameter should be "answer_message".

 Comment: "sendQuery()" could be better named as the brief description is
 "Initiate resolving".  How about "resolve()"?

 Comment: !RecursiveQuery: although documented, this does seem a bit of a
 trap for the unwary - whether the class acts as a resolver or forwarder
 depends on whether the upstream servers are set. Will there not be
 something in the configuration that controls the functionality?

 '''src/lib/nsas/nameserver_entry.h'''[[BR]]
 The forward declaration of !ResolverInterface is commented out, not
 removed.

 '''General'''[[BR]]
 Comment: currently no tests in src/lib/resolve, although admittedly, it is
 difficult to see what could be tested.

-- 
Ticket URL: <http://bind10.isc.org/ticket/494#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development