BIND 10 #517: Empty node processing in MemoryZone difficult Part

BIND 10 Development do-not-reply at isc.org
Wed Feb 2 03:19:38 UTC 2011


#517: Empty node processing in MemoryZone difficult Part
-------------------------------------+-------------------------------------
                 Reporter:  hanfeng  |                Owner:  jinmei
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110209
                Component:  data     |           Resolution:
  source                             |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  0.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Some higher level points:

  - we agreed on adding [tracXXX] to commit logs.  from now on, please add
    this when you make commits.
  - there's still common style violation (directly fixed).  writing a
 checker
    script may be a nice side work if you need to kill your time in
 vacation:-)

 I made overall cleanups on documentation and tests, and directly committed
 proposed changes.

 I also some non trivial changes:

  - use the absolute maximum for RBT_MAX_LEVEL.  check this through tests
  - change exceptions to assert in private functions.  see log and
 comments.
  - have RBTree methods throw exceptions against bogus chains.

 My changes can be retrieved by "git diff 2565b9fe".

 If these changes are okay, please merge it to trunk (or I can do that if
 you don't have time).  If not, please respond in this ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/517#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list