BIND 10 #452: IntervalTimer should accept time interval in milliseconds
BIND 10 Development
do-not-reply at isc.org
Wed Feb 2 12:15:42 UTC 2011
#452: IntervalTimer should accept time interval in milliseconds
-------------------------------------+-------------------------------------
Reporter: | Owner: UnAssigned
y-aharen | Status: reviewing
Type: | Milestone:
enhancement | Resolution:
Priority: major | Sensitive: 0
Component: | Add Hours to Ticket: 0
Unclassified | Total Hours: 0
Keywords: |
Estimated Number of Hours: 0.0 |
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by y-aharen):
Replying to [comment:3 fujiwara]:
> Internal Review by fujiwara:
>
> The differences from latest merge
(7c89825c3a8fe2c64fd046cf17ef90fd12836fd2) seems OK for me.
Thank you for your review.
> I have one opinion. But I don't like to stop the process.
> The fix changed the unit of time duration, but I prefer generic method
of specifying duration time. For example, using variable type as
boost::posix_time::time_duration and specifying the value as
boost::posix_time::milliseconds(100) seem to be generic. Please consider
generic method of specifying duration time in the future.
I see. We should discuss it when !IntervalTimer will be used in the other
place.
I discussed with Fujirawa-san about the configuration "statistics-
interval". It should be accept interval in seconds, not in milliseconds. I
made some changes at 2931606d7c3d6709284788890b016ff434d0f5e2.
The proposed changelog entry is this:
{{{
TBD. [bug] y-aharen
IntervalTimer: Modified the interface to accept interval in
milliseconds. It shortens the time of the tests of IntervalTimer.
(Trac #452, git TBD)
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/452#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list