BIND 10 #452: IntervalTimer should accept time interval in milliseconds

[BIND 10 Development]

#452: IntervalTimer should accept time interval in milliseconds
-------------------------------------+-------------------------------------
                 Reporter:           |                Owner:  y-aharen
  y-aharen                           |               Status:  reviewing
                     Type:           |            Milestone:
  enhancement                        |           Resolution:
                 Priority:  major    |            Sensitive:  0
                Component:           |  Add Hours to Ticket:  0
  Unclassified                       |          Total Hours:  0
                 Keywords:           |
Estimated Number of Hours:  0.0      |
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 Can I point out one thing? The number "86400" is hard-coded as the
 following lines.
 {{{
 diff --git a/src/bin/auth/config.cc b/src/bin/auth/config.cc
 index 1f258e3..1593194 100644
 --- a/src/bin/auth/config.cc
 +++ b/src/bin/auth/config.cc
 @@ -179,7 +179,11 @@ public:
      virtual void build(ConstElementPtr config_value) {
          const int32_t config_interval = config_value->intValue();
          if (config_interval < 0) {
 -            isc_throw(AuthConfigError, "negative statistics-interval
 value: "
 +            isc_throw(AuthConfigError, "negative statistics interval
 value: "
 +                      << config_interval);
 +        }
 +        if (config_interval > 86400) {
 +            isc_throw(AuthConfigError, "Too long statistics interval
 value: "
                        << config_interval);
          }
          interval_ = config_interval;
 }}}
 I think it should log the maximum number for the interval time with the
 raised error message, for example like "This value should be equal to or
 lower than 86400". Otherwise this number should be documented in a manual
 somewhere.

-- 
Ticket URL: <http://bind10.isc.org/ticket/452#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development