BIND 10 #452: IntervalTimer should accept time interval in milliseconds

BIND 10 Development do-not-reply at isc.org
Fri Feb 4 08:44:39 UTC 2011


#452: IntervalTimer should accept time interval in milliseconds
-------------------------------------+-------------------------------------
                 Reporter:           |                Owner:  vorner
  y-aharen                           |               Status:  reviewing
                     Type:           |            Milestone:
  enhancement                        |           Resolution:
                 Priority:  major    |            Sensitive:  0
                Component:           |  Add Hours to Ticket:  0
  Unclassified                       |          Total Hours:  0
                 Keywords:           |
Estimated Number of Hours:  0.0      |
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by y-aharen):

 Replying to [comment:8 naokikambe]:
 > Can we add a test case for this new limitation? Following is an example.
 > {{{
 > diff --git a/src/bin/auth/tests/config_unittest.cc
 b/src/bin/auth/tests/config_unittest.cc
 > index 0e0aee9..0408613 100644
 > --- a/src/bin/auth/tests/config_unittest.cc
 > +++ b/src/bin/auth/tests/config_unittest.cc
 > @@ -365,5 +365,10 @@ TEST_F(StatisticsIntervalConfigTest, badInterval) {
 >      EXPECT_THROW(parser->build(Element::fromJSON("2.5")),
 >                   isc::data::TypeError);
 >      EXPECT_THROW(parser->build(Element::fromJSON("-1")),
 AuthConfigError);
 > +
 > +    // checking error raised when the timer interval is the maximum
 > +    // number(86400) or greater than it.
 > +    EXPECT_NO_THROW(parser->build(Element::fromJSON("86400")));
 > +    EXPECT_THROW(parser->build(Element::fromJSON("86401")),
 AuthConfigError);
 >  }
 >  }
 > }}}

 Thank you for the suggestion. Added a test of the limitation of statistics
 interval at 24bb934f0ad2732c50730187376d96ddadefecbc.

-- 
Ticket URL: <http://bind10.isc.org/ticket/452#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list