BIND 10 #550: wildcard handling for memory zone: load

BIND 10 Development do-not-reply at isc.org
Sat Feb 5 08:06:44 UTC 2011


#550: wildcard handling for memory zone: load
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:           |               Status:  accepted
  enhancement                        |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110209
                Component:  data     |           Resolution:
  source                             |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Branch trac550 is ready for review.

 It begins with a refactoring of tests:
 bc1b548a3828f5cd722496dd8eb5c09fc1f95187
 I hope this one is simpler (although we need to provide RDATA even when
 it's not necessary for the test) and can be extended more easily.
 This change is irrelevant to the topic of this ticket, and it
 shouldn't change the existing test semantics.

 The rest of the change is basically a straightforward implementation
 of the plan.  Some possibly non trivial parts are:
  - I changed the "callback" property of RBNode to generic "flags" and
    adjusted the interface accordingly.  both "callback" and "wild" are
    now implemented as flags.
  - now the add() method has become pretty large and is getting
    unreadable, I refactored the code by moving the initial validation
    to a separate helper method: b832c3c975bcae66717ce28e392a189887b6f08f
  - as noted in the test code, the current test relies on an incomplete
    version of "empty node" support (I incorporated it from #507), and
    it relies on its "incompleteness".  Once we fully support empty
    nodes the tests will become meaningless.  The plan is to clean up
    when we complete #551.
  - I couldn't find a way to test the part of setting "wild" mark.  so
    I'd defer that part of test to #551 (testing wildcard find() will
    indirectly test the "wild" marking)

-- 
Ticket URL: <https://bind10.isc.org/ticket/550#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list