BIND 10 #558: Disable log4cxx dependency in logging API
BIND 10 Development
do-not-reply at isc.org
Thu Feb 10 18:48:16 UTC 2011
#558: Disable log4cxx dependency in logging API
-------------------------------------+-------------------------------------
Reporter: stephen | Owner: jinmei
Type: defect | Status: reviewing
Priority: major | Milestone: R-Team-
Component: logging | Sprint-20110222
Keywords: | Resolution:
Estimated Number of Hours: 2.0 | Sensitive: 0
Billable?: 1 | Add Hours to Ticket: 0
Internal?: 0 | Total Hours: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
I'm looking into the changes, but a couple of trivial nits first:
- in the new change you reverted parentheses around return, against
the style guideline, e.g.
{{{
- return (isc::strutil::trim(current_time));
+ return isc::strutil::trim(current_time);
}}}
Please fix them.
- there are some redundant white spaces in blank lines, e.g.
{{{
+ "\n";
+
+ // Declare the message symbols themselves.
}}}
git diff with colors (or colours:-) highlights these. I suggest you
check the result of git diff and fix such trivial issues.
--
Ticket URL: <http://bind10.isc.org/ticket/558#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list