BIND 10 #505: DNAME Implementation

[BIND 10 Development]

#505: DNAME Implementation
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110223
                Component:           |           Resolution:
  b10-auth                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  2.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:23 vorner]:

 The changes look okay.

 As for this point:
 {{{
              * Does anybody have a clue why, if the Name::MAX_WIRE is put
              * directly inside ASSERT_EQ, it fails to link and complains
              * it is unresolved external?
              */
             size_t max_len(Name::MAX_WIRE);
 }}}

 You can do it if you teach the compiler about the symbol.  See, e.g.,
 the case for Name::MAX_LABELS in rbtree_unittest.cc.  (I've not
 figured out exactly why we need this, though)

 But it may not be concise enough and may not actually look better
 (unless we want to use that constant multiple times).  Either way is
 okay for me.  If you keep the current style, I'd make max_len 'const
 size_t'.

-- 
Ticket URL: <https://bind10.isc.org/ticket/505#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development