BIND 10 #569: split up asiolink.[h|cc]

BIND 10 Development do-not-reply at isc.org
Mon Feb 14 14:25:15 UTC 2011


#569: split up asiolink.[h|cc]
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  jelte
                     Type:  task     |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110222
  Unclassified                       |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  3.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 Reviewed commit d8989e0a05ae7a453a6768f2ff4019d41ad84aab

 Very good, thanks for this - I think it will make modifying and using the
 ASIO libraries much easier.  Just a few minor points:


 '''dns_answer.h'''[[BR]]
 This is an empty file in the top-level directory.

 '''src/lib/asiolink/coroutine.h'''[[BR]]
 Comment: as this is third-party code, should this be in the "ext"
 directory?

 '''src/lib/asiolink/dns_service.cc'''[[BR]]
 Should use "#include <asiolink/tcp_server.h>" to be consistent with other
 includes.

 '''src/lib/asiolink/io_service.{h,cc}'''[[BR]]
 These should really be named ioservice.* to be consistent with the rest of
 the io* files - although come to think of it, the other io* files should
 really be renamed with an underscore between "io" and the rest of the file
 name to be consistent with names such as udp_query.*

 '''src/lib/asiolink/simple_callback.h'''[[BR]]
 This should include iomessage.h (the header includes a method with an
 argument of type "const IOMessage&").

-- 
Ticket URL: <https://bind10.isc.org/ticket/569#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list