BIND 10 #558: Disable log4cxx dependency in logging API
BIND 10 Development
do-not-reply at isc.org
Mon Feb 14 20:32:41 UTC 2011
#558: Disable log4cxx dependency in logging API
-------------------------------------+-------------------------------------
Reporter: stephen | Owner: jinmei
Type: defect | Status: reviewing
Priority: major | Milestone: R-Team-
Component: logging | Sprint-20110222
Keywords: | Resolution:
Estimated Number of Hours: 2.0 | Sensitive: 0
Billable?: 1 | Add Hours to Ticket: 0
Internal?: 0 | Total Hours: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:18 stephen]:
>
> > I'm still not sure if it's always guaranteed. Isn't it possible that
> > the linker detect we actually don't need "initializer" and removes the
> > corresponding code as optimization?
> I think it's unlikely under Unix, but possible under Windows Visual
Studio. The latter contains a "Whole program optimization" switch that
defers the optimization to link time. However I would have thought that
the optimization would detect that !MessageInstantiator refers to
!MessageInitializer whose constructor invokes !MessageDictionary which is
referred to by other modules in the program. It will be interesting to
find out when we finally port BIND10 to Windows - although I suspect that
that will be one of our lesser problems :-)
Okay. Please leave some notes about this point somewhere (maybe in
compiler/message.cc)?
Oh, and by looking at message.cc I noticed the doxygen style comment
mentions a non existent option:
{{{
/// If \c -p is specified, the C++ files are not written; instead a Python
file
/// of the same name (but with the file extension .py) is written.
}}}
I've also made a couple of minor editorial fixes and pushed them to
the central repo.
Other points look okay, and I don't think we need further review.
Please make any suggested changes above with your discretion and merge
it.
--
Ticket URL: <http://bind10.isc.org/ticket/558#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list