BIND 10 #384: Bindctl doesn't show complicated config structures

BIND 10 Development do-not-reply at isc.org
Tue Feb 15 14:18:57 UTC 2011


#384: Bindctl doesn't show complicated config structures
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  zhanglikun
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:  bind-    |  Sprint-20110222
  ctl                                |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  5.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by zhanglikun):

 Replying to [comment:11 jelte]:
 > >
 > > '''bindctl/bindctl-source.py.in'''
 > > 1. there is one new added parameter for command "config show", I am
 not sure if we really need it, I prefer to always show all child elements
 for specified identifier.
 > > when user doesn't specify the identifier for command "config show",
 just show all elements recursively for all modules.
 > >
 >
 > hmm, that would probably not be that hard to change, but what i'm afraid
 for is that this would now be easy-to-use, but as the number of options
 increase (and for instance, if we have config for every zone), we might
 want to default to not-all. Shall we discuss this with the rest?

 OK, make sense, let's keep it.

 When I doing the test, I find some problem.

 the following command has error.
 {{{
 config go Resolver/
 }}}

 but it works with the following command
 {{{
 config go /Resolver/
 }}}


 and also I find after "config go Resolver/",  there is no way to config go
 to sub config items,
 eg. I can't "config go forward_address".

 When I check the code, I find my above review comments had error, the
 following codes should not be removed. Sorry for that. It will be used
 after command "config go /Resolver/foward_address", when running the
 following command.
 {{{
 Resolver/foward_address>config set [0]/address "1.1.1.1"
 }}}

 {{{
 561                     if cmd.params['identifier'].startswith('['):
 562                         identifier = identifier[:-1]
 }}}

 so commit "086b420bfba5b31f13e2828ca1be842a8faad4aa" should be reverted.

 All others looks nice.

-- 
Ticket URL: <http://bind10.isc.org/ticket/384#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list